simplify condition for platform_machine

h-vetinari commented 2 years ago

From discussion here, CC @rgommers

We can replace the direct negation of platform_machine=='arm64' and platform_system=='Darwin' above with only platform_machine not in ('arm64') because there are no machines that satisfy arm64+non-Darwin.

h-vetinari commented 2 years ago

Seems this is running into a complication with packaging: https://github.com/pypa/packaging/issues/552

h-vetinari commented 2 years ago

@rgommers This should now work, and is IMO a nice simplification.

rgommers commented 2 years ago

This | syntax is supported by packaging. One concern I had is that not all install tools support this, but it seems to be okay - I've verified that packaging is vendored or depended on by Pip, Poetry and PDM. Hopefully there are no other half-baked implementations for parsing this grammer floating around.

rgommers commented 2 years ago

From discussion here,

Copying what @h-vetinari wrote there: "I understand that this contains the negation of the Darwin+arm64 from above, but since aarch64 and arm64 are distinguished, arm64 does not seem possible with anything but Darwin?"

As of today:

arm64 is indeed macOS-specific in implementations of packaging infra.
https://peps.python.org/pep-0508/#environment-markers defines platform_machine and other such markers, but does not define what markers exist
https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/ is a good reference page. There's no single place where all tags are listed though. https://peps.python.org/pep-0600/ lists all currently known Linux tags.

So this should be safe enough, at least right now.

scipy / oldest-supported-numpy

simplify condition for platform_machine #56