scipy / scipy-sphinx-theme-v2

New version of scipy-sphinx-theme to be used across NumPy documentaton page and subpages.
https://pr-72-scipy-sphinx-theme-v2.surge.sh/
3 stars 5 forks source link

Style: Link coloring makes links anonymous #60

Open fuglede opened 4 years ago

fuglede commented 4 years ago

Quick test: In the screenshot below, there are code blocks of two colors, black and red. Out of these, which ones are links to other documentation pages, and which ones aren't?

Screenshot from 2019-11-27 15-23-23

I got it wrong myself: The black ones, which mostly fade in with the text, are links, but the red ones are not. Chances are that this is something that one will get used to quickly, but it might not be immediately apparent. Compare with the old documentation where all links are blue and clearly separated from the surrounding text. A solution could be to ensure that code links and non-code links have the same color.

On a separate note, the table in the screenshot seems to have some issues: The "Notes" column in the tomaxint row is formatted strangely. But, this is also the case in the old documentation, so this is probably just a case of markup not being done quite properly.

Shekharrajak commented 4 years ago

Thanks for the observation and comment, we will look into that.

Shekharrajak commented 4 years ago

I find that this is the default behavior of default theme readthedoc, so I am not sure whether it should be changed or not.

rgommers commented 4 years ago

I'd prefer to change it, it is pretty confusing. The old SciPy Sphinx theme gets it right I think.