search

scipy / scipy-sphinx-theme-v2

New version of scipy-sphinx-theme to be used across NumPy documentaton page and subpages.
https://pr-72-scipy-sphinx-theme-v2.surge.sh/
3 stars 5 forks source link

Text spread over too much horizontal space #68

Closed peterbell10 closed 4 years ago

peterbell10 commented 4 years ago

Viewing the website on a 1440p monitor with firefox maximised, the text is spread out over too much horizontal space making it awkward to read.

scipy_sphinx_theme

Compare this to readthedocs' theme which limits the maximum width, keeping content closer together and easier to read (although I would prefer if everything was centred) readthedocs

Shekharrajak commented 4 years ago

Thanks for sharing the screenshot. Yes! It would be better if we make specific maximum fixed width for body content. Previously I was focusing on how to use the whole width to display the content.

fuglede commented 4 years ago

Note that this (or at least something equivalent or very similar) is the first half of #58 as well, but that one has been marked as fixed.

Shekharrajak commented 4 years ago

Max width is set: #73

Screenshot 2020-01-12 at 12 56 02 PM
Shekharrajak commented 4 years ago

@fuglede can you please review and check the demo url: https://pr-73-scipy-sphinx-theme-v2.surge.sh/ for the PR #73

fuglede commented 4 years ago

Sure. I think it's much better! One thing that did strike me was that the blue side bar feels a bit "floaty", but I'm sure I'm just biased by how Read The Docs normally looks, and how it's left-aligned by default.

Shekharrajak commented 4 years ago

Thanks for the review and comment @fuglede ! The base theme is Read The Doc and it is customized to fulfill the NumPy Doc requirement. I am closing this now. Feel free to open it if you want to discuss anything else.