MAINT: try fixing a collection error under pytest 8.1.x

scipy / scipy_doctest

Floating-point aware doctesting

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

MAINT: try fixing a collection error under pytest 8.1.x #143

Closed ev-br closed 5 months ago

ev-br commented 5 months ago

closes gh-142 if successful

ev-br commented 5 months ago

The diff is messier then it is: this PR only adds a branching on pytest < 8 or not (hence next indent level for what was there), and uses a simpler version takes from pytest 8.1.0. To make diff clearer, select settings -> hide whitespace in the review panel.

WDYT @Sheila-nk ?

Sheila-nk commented 5 months ago

Great job on this PR and for catching the bug introduced by pytest's new release! The solution looks straightforward, and it's awesome to see that pytest>8 tests are passing. 🚀

ev-br commented 5 months ago

pytest 8.1.0 is yanked from pypi :-). That said, the else: branch added here tracks the current pytest master, the failure was in the branch taken from pytest 7.4.x, so we're probably good for now. Merging, thanks for the review Sheila.

Sheila-nk commented 5 months ago

Got it! Thank you for the clarification!