ENH: Execute doctests in numpy unfuncs and compiled functions

scipy / scipy_doctest

Floating-point aware doctesting

BSD 3-Clause "New" or "Revised" License

5 stars 4 forks source link

ENH: Execute doctests in numpy unfuncs and compiled functions #91

Closed Sheila-nk closed 1 year ago

Sheila-nk commented 1 year ago

used scpdt's find_doctests to discover doctests in public objects.

Sheila-nk commented 1 year ago

Here is scipy's doctest log after using this branch of the plugin to run doctests: doctest.log

ev-br commented 1 year ago

Could you also compare the logs please?

Sheila-nk commented 1 year ago

@ev-br Here is the current doctest log after executing doctests on scipy using this scpdt branch: doctest.log

ev-br commented 1 year ago

Okay, while this is still mighty scary, let's get this in to simplify iterating on scipy. I'm going to do a holistic review anyway, this will be a refactor opportunity.

Sheila-nk commented 1 year ago

The main issues that still need looking into are:

[ ] doctest log formatting
[ ] ensure imported objects are not collected for doctesting I will open issues to follow up.

ev-br commented 1 year ago

The first bullet in https://github.com/scipy/scipy/pull/19242#issuecomment-1722192490 shows that there's an issue with an implementation of strategy="api". array from numpy is not a public object, so it should not be doctested.