Closed piannucci closed 1 year ago
FWIW, https://github.com/pv/scipy-work/commit/196829a3fbe4d41a228445331131f206fae89599, not sure if useful any more though
Some comments based on a quick browse:
fileno()
integers themselves.if sys.version_info[0] >= 3
statements is enough.@piannucci this PR needs a rebase now. When you push an update then the TravisCI tests will run (just enabled them) in order to verify that nothing broke on Python 2.6 / 2.7.
Okay, rebased. Also did some housekeeping. Can someone set up Travis to test Python 3.4?
I think you can set up the test yourself -- edit .travis.yml and copypaste the python 2.7 section in the beginning.
Is it a problem that through scipy.six we've added a dependency on scipy itself?
Is it a problem that through scipy.six we've added a dependency on scipy itself?
That's the part that I just ripped out, so you put it back by accident in the rebase it looks like. The dependency isn't needed.
The tests failed, but the log only shows the scipy build.
My bad. Still a ton of conditional code to put in to restore Python 2 compatibility.
Hm, that's a lot more errors than I get on my machine. GCC seems unhappy.
Test failures on Python 3.4 down to 2 on Travis, zero on my machine.
Though there is some spew from a blitz expression that fails to compile. Which is really two bugs: one in weave.blitz, one in the test.
Hm, I'm seeing non-deterministic test failures.
Opening a new PR extending https://github.com/scipy/weave/pull/1. Not all tests pass, but my own applications work correctly.
Open questions remain regarding how str/bytes should be handled, how file objects should be handled, and how/if the codebase can simultaneously support Python 2 and 3.