scipy / weave

Weave - tools for including C/C++ code within Python code.
https://pypi.org/project/scipy-weave/
Other
55 stars 27 forks source link

Fix numpy issues (package currently not useable after install) #21

Closed mstimberg closed 1 year ago

mstimberg commented 1 year ago

I am well aware of scipy-weave being basically in archive mode, but I noticed that the current package does not declare the numpy dependency and is therefore not useable in an environment built from scratch:

$ pip install scipy-weave
$ python -c 'import weave'
Traceback (most recent call last):
  [...]
ModuleNotFoundError: No module named 'numpy'

This attempts to be a minimal fix to make it work with numpy 1.24 – making it work with numpy≥1.25 would be considerable more complex, since the test infrastructure relies on deprecated numpy testing tools for nose that were removed in 1.25. With this PR, it at least works on my linux-x86_64 machine with Python 3.9 and numpy 1.24, but I have to admit I did not do any testing beyond that…

$ python -c 'import weave; weave.test("full")'
[...]
Ran 446 tests in 110.589s

OK (KNOWNFAIL=3)
mstimberg commented 1 year ago

Thank you @rgommers .

Is it important to you to tag another release with these changes and upload that to PyPI?

Not important for me, so if you wouldn't do it otherwise, please do not bother.