Wrong error message when trying to re-register with existing account.

sciserver / login-portal

The portal for DIBBs Single Sign On

MIT License

0 stars 1 forks source link

Wrong error message when trying to re-register with existing account. #13

Closed dobos closed 6 years ago

dobos commented 8 years ago

Instead of a message saying username is taken the following is displayed:

Response status code does not indicate success: 401 (Unauthorized).

dmedv commented 8 years ago

What happens, I believe, is this:

it looks for a CasJobs user with the same name (and finds it);
it tries to authenticate (in CasJobs, not in Keystone) with the password you provided in the registration form; the password does not match the old CasJobs password, so 401 is returned.

401 response is the correct one, but I agree that the error message is a bit confusing. I could change it to something like: "Failed to authenticate with CasJobs using an existing username".

dmedv commented 8 years ago

... but I should probably check if a Keystone user with the same name exists, before trying to authenticate with CasJobs.

dmedv commented 8 years ago

It will now display this error message: "User name already exists". Deployed the updated version to scitest02. Marking as fixed.

dmedv commented 8 years ago

Deployed to test.preprod

knservis commented 7 years ago

Has this been deployed? I just got the same error