v1.0.0:SD_WU_3:Needs warning for uploading duplicate file name.

[raddick]

What happens now - does the new file overwrite the old file with the same name?

It sounds like this is an error handling and documentation issue rather than a code enhancement issue.

[jkim485]

The new file overwrites the file with the same name.

[raddick]

Not a showstopper, I think, but definitely a bug.

[jkim485]

Tested on scidrive 2: the issue has not been fixed.

[dimm0]

@raddick If a bunch of files are queued for upload (say, 5000), and 1 file in the middle is a duplicate, the whole queue can be stopped in the middle of operation waiting for user confirmation. Is that a desired behaviour? I'd think it's better to upload all files. User should know what he's doing.. To implement this I'll have to check every file for existence on server before uploading, which will also slow down the upload of many small files.

[jkim485]

Need to decide whether to give a warning or an error(i.e., not uploading), for all writing a file with duplicate filename.

[jkim485]

https://github.com/idies/scidrive-ui/issues/13#issuecomment-133216658

From: Dmitry Mishin [mailto:notifications@github.com] Sent: Thursday, August 20, 2015 7:56 PM To: idies/scidrive-ui scidrive-ui@noreply.github.com Cc: jkim485 jaiwonk@hotmail.com Subject: Re: [scidrive-ui] v1.0.0:SD_WU_3:Needs warning for uploading duplicate file name. (#13)

If a bunch of files are queued for upload (say, 5000), and 1 file in the middle is a duplicate, the whole queue can be stopped in the middle of operation waiting for user confirmation. Is that a desired behaviour? I'd think it's better to upload all files. User should know what he's doing.. To implement this I'll have to check every file for existence on server before uploading, which will also slow down the upload of many small files.

— Reply to this email directly or view it on GitHub https://github.com/idies/scidrive-ui/issues/13#issuecomment-133216658 . https://github.com/notifications/beacon/AMWwg9MVsi8d5M4ME4mELToOq1ohQktdks5opmB7gaJpZM4FOP8v.gif

[mikear69]

Unconditional overwriting without warning is not acceptable, ever.

In the upload of lots of files,we could do the following (a) the code could be modified to create a new copy, like Windows Explorer does e.g. if File.txt exists, it could save a duplicate as File(2).txt. However, seeing the earlier issue that files cannot be renamed, the user would be left with the file called “File(02).txt” even if they manually deleted the older “File.txt”. (b) An alternative is that the files are not overwritten, but any duplicates are collected together in a list for a single message to be displayed at the end so the user can confirm then (it could be a checkbox list) – SciDrive then goes back and uploads/overwrites them (c) We do what Dima says will take ages, and just check if a file is already there ahead of time, then create a list to report to the user before files are copied. This is like option (b) except the message comes first rather than last. It will be slower than (b) because of the checks, but it will get it over with.

What do you think? My current thoughts are with option (b).

[jkim485]

The option (a) seems the way to do but i agree with your concern.

Either (b) or (c) would be fine. I don't quite understand why executing option(c) would be slower that (b)?

[jkim485]

The option (a) seems the way to do but i agree with your concern.

Either (b) or (c) would be fine. I don't quite understand why executing option(c) would be slower that (b)?

https://github.com/idies/scidrive-ui/issues/13

From: mikear69 [mailto:notifications@github.com] Sent: Thursday, October 08, 2015 10:58 AM To: idies/scidrive-ui scidrive-ui@noreply.github.com Cc: jkim485 jaiwonk@hotmail.com Subject: Re: [scidrive-ui] v1.0.0:SD_WU_3:Needs warning for uploading duplicate file name. (#13)

Unconditional overwriting without warning is not acceptable, ever.

In the upload of lots of files,we could do the following (a) the code could be modified to create a new copy, like Windows Explorer does e.g. if File.txt exists, it could save a duplicate as File(2).txt. However, seeing the earlier issue that files cannot be renamed, the user would be left with the file called “File(02).txt” even if they manually deleted the older “File.txt”. (b) An alternative is that the files are not overwritten, but any duplicates are collected together in a list for a single message to be displayed at the end so the user can confirm then (it could be a checkbox list) – SciDrive then goes back and uploads/overwrites them (c) We do what Dima says will take ages, and just check if a file is already there ahead of time, then create a list to report to the user before files are copied. This is like option (b) except the message comes first rather than last. It will be slower than (b) because of the checks, but it will get it over with.

What do you think? My current thoughts are with option (b).

— Reply to this email directly or view it on GitHub https://github.com/idies/scidrive-ui/issues/13#issuecomment-146571172 . https://github.com/notifications/beacon/AMWwg1zDDWk_lc0LWCQpgx0x9MnMKSB8ks5o5nvpgaJpZM4FOP8v.gif

[dimm0]

Are we done with this?

[jkim485]

yes. I have tested it and confirmed the fix.

[jkim485]

Could you fix on pre-product? Thank you.

[dmedv]

Fixed on preprod. Closing.