sciserver / scidrive-ui

Web UI for scidrive
http://www.scidrive.org
Apache License 2.0
0 stars 0 forks source link

v1.0.0:SD_WU_6: File Delete option should not be available from shared read only view. #17

Closed jkim485 closed 8 years ago

jkim485 commented 9 years ago

Users get an option to delete a selected file from the shared view but the selected file is not deleted as it should be. This option must not be available from shared read only view.

raddick commented 9 years ago

This means that the user could be at risk of deleting files while in read-only mode, which is going to be seriously frustrating for them. GIven that, I'd call this a bug rather than an enhancement.

jkim485 commented 9 years ago

Also, the view for the Share shows the icons for "Create New File" and "Create New Directory" when the Share is read-only. It does not let you create files or folders (correctly) but having the icons there is wrong.

jkim485 commented 9 years ago

Tested on scidrive 2: the issue has not been fixed.

dimm0 commented 9 years ago

For read-only shares these actions will return error, no files will be deleted or created. For now there's no way for the portal to know if a share is read-only or not.

dimm0 commented 8 years ago

Also the buttons should appear when panel is switched to normal, non-shared view. Or if two panels are open, one with share, another with normal. I would leave as it is for now. In read-only view it will give an error for each prohibited action.