search

sciserver / scidrive-ui

Web UI for scidrive
http://www.scidrive.org
Apache License 2.0
0 stars 0 forks source link

Remove SciDrive Dropdown for server #49

Closed jkim485 closed 6 years ago

jkim485 commented 8 years ago

i.e. the thing on the top RHS that currently shows scidev09 and scidev13. please see https://github.com/sciserver/scidrive-ui/issues/48.

dimm0 commented 8 years ago

Is it still an issue? Why do you want to remove one?

jkim485 commented 8 years ago

Mike thinks that the end-user should NOT SEE the drop-down choosing server leaving the underlying functionality as it is.

jkim485 commented 8 years ago

Tested on pre-product: still displays the server name. @Mike at the moment on the drop-down there is only "preprod.scidriveorg on the list..is this acceptable?

jkim485 commented 8 years ago

discussed with Mike and concluded to remove the server dropdown.

mtaghiza commented 8 years ago

Fixed. First tried to comment out the data-dojo-attach-point="loginSelect" in file ScidrivePanel.html, but then Scidrive wouldn't load. So the easiest fix is to add a "visibility:hidden" in its style attribute. Although the user could bring the dropdown back to visible when doing an element inspect in the browser, that wouldn't make any harm anyways, afaik.

jkim485 commented 8 years ago

Tested okay.