sciserver / scidrive-ui

Web UI for scidrive
http://www.scidrive.org
Apache License 2.0
0 stars 0 forks source link

Anonymous sharing must not require logging into scidrive in order to view shared folder #70

Open jkim485 opened 8 years ago

jkim485 commented 8 years ago

Test on pre-prod

  1. User A chooses folder and selects sharing icon.
  2. Select ‘no group’ and ‘read-only’.
  3. Create share.
  4. Send the link to other user B.
  5. B enters the link to his browser.
  6. B is asked to login to sciserver.

The expected behavior is that B is not asked to look into scidrive/SciServer.

dimm0 commented 8 years ago

Confirming the behaviour Is it true that "no group" means everyone, and not all registered sciserver users?

jkim485 commented 8 years ago

according to the interface it says: no group: anonymous access.

I sent you an question earlier and your reply was that anonymous access is for accessing w/o registration..

jkim485 commented 8 years ago

ps we need to get rid of option for choosing a group.

jkim485 commented 8 years ago

Share doesn't work:

  1. Click on option for share for a selected folder.
  2. Click create share with an option "read only" checked.
  3. Copy share URL.
  4. Paste the copied share URL to a new browser, got the following error message HTTP 404 status HTTP Status 404 - /scidrive/scidrive.html%3Fshare%3DRqJya9QTW9eQaJT

type Status report

message /scidrive/scidrive.html%3Fshare%3DRqJya9QTW9eQaJT

description The requested resource is not available.

jkim485 commented 8 years ago

Question: if user unselect "read-only" option for create share option,, how is this different from the case if read-only option is selected?

dimm0 commented 8 years ago

REad-only means user can't upload and delete files in that folder

dimm0 commented 8 years ago

URL is fixed, but now there's an issue with uploading and downloading files in non-Read Only shares. TBD

jkim485 commented 8 years ago

Thanks for the fix. Unfortunately I cannot do test it right now because it hangs when log into scidrive.

dimm0 commented 8 years ago

It hangs when nobody's testing it for long :)

jkim485 commented 8 years ago

:(

dimm0 commented 8 years ago

We're working on it...

jkim485 commented 8 years ago

I am now able to log into scidrive. Tried anonymous sharing (read-only): 1 user a creates anonymous sharing. 2 user b enters the share URL to browser. 3 user B can access to shared folder.(see comments* below in this cell) 4 if user a removes sharing of the shared folder user B could do not access to shared a folder any longer: scidrive gives an error message including "log out".

Comments* for anonymous read-only sharing UI(eg, what user B sees in step three above) 1 log out button: not sure whether it's necessary to have log out option for anonymous sharing. 2 create folder/create file from URL buttons: user B was allowed to click 'create folder' as well as 'create folder from URL' buttons . But when user B click submit after filling up necessary information for these two options nothing happened. No error message or warning appeared on the UI. I think it's better not to make these options visible for read-only sharing. @mikear69 : what do you think about these comments? I talked to Mike about it and he agrees on 'hiding' these two options. I will create a separate issue about it.

jkim485 commented 8 years ago

Tested anonymous sharing (writing enabled) 1 user A creates anonymous sharing write enabled. 2 user B enters the share URL to browser. 3 user B can access to shared folder.(see comments* below in this cell)

  1. User B is able to create a folder under shared folder. 5 user B is not able to create a file from URL: entered necessary information on the dialog box on creating files from URL and clicked submit but nothing happened.
  2. user A removes sharing of the shared folder user B could do not access to shared a folder any longer: scidrive gives an error message including "log out".