search

scissor-project / open-scissor

OpenSCISSOR provisioning and orchestration
Apache License 2.0
2 stars 0 forks source link

updated d-streamon, updated libssl-dev, fixed d-streamon errors #62

Closed Davidepad closed 6 years ago

Davidepad commented 6 years ago

Description of the Change

Alternate Designs

Benefits

Possible Drawbacks

Applicable Issues

ferrarimarco commented 6 years ago

Hi @Davidepad

Can you please:

  1. Squash these 4 commits in a single one
  2. Write details about what you did in the commit message
  3. Fix the errors in the build (see the Travis build output): some scripts are not passing the validation

Thanks!

ferrarimarco commented 6 years ago

@Davidepad one last request: can you please modify the commit message?

The first line (summary) should be no more than 72 chars. After that I'll wait for the build to finish and then I can merge. Also, it's not necessary to put an issue reference (like you did, issue #62) because there is no such issue :)

Thanks!

Davidepad commented 6 years ago

@ferrarimarco I modified the commit message, it should be better.

The build fails but it does not seem to be an error related to D-streamon.

ferrarimarco commented 6 years ago

@Davidepad I fixed the prelude-manager (and prewikka) builds. Can you please rebase this PR on development? So we can check we are at least able to build the D-Streamon images.

UPDATE: I pushed another commit in the development branch that upgrades libssl-dev to fix package installation in d-streamon-master, but there are other issues. Let's check if your fixes apply

Davidepad commented 6 years ago

@ferrarimarco I saw the error logs, the changes in this branch repair that issue too.

I did the rebase.

ferrarimarco commented 6 years ago

@Davidepad see the error log, d-streamon-master is not building: https://travis-ci.org/scissor-project/open-scissor/builds/364495772

Davidepad commented 6 years ago

@ferrarimarco In my branch there are all the changes necessary to compile D-Streamon.

The last compilation of my branch compiles both the master and the slave:

https://travis-ci.org/scissor-project/open-scissor/builds/364243615

Accepting the PR for development and compiling D-Streamon should work.

ferrarimarco commented 6 years ago

I rebased the branch on the latest development. Waiting for the builds to complete...