search

scissor-project / open-scissor

OpenSCISSOR provisioning and orchestration
Apache License 2.0
2 stars 0 forks source link

fixed login, add ssh inside dockerfile #63

Closed Davidepad closed 6 years ago

Davidepad commented 6 years ago

Description of the Change

Fixed a problem related to the login in the D-Streamon gui. Added ssh into the containers to make Ansible work

Alternate Designs

No other alternative, Ansible requires ssh to work

Benefits

Now D-streamon master is able to configure the d-streamon slave. And everything works via GUI

Possible Drawbacks

I have not found any negative effects

Applicable Issues

ferrarimarco commented 6 years ago

Can you please add some details about the pull request by filling the template?

Please note that adding a running SSH daemon in a container is considered a bad practice. Why do you need such feature?

If you need to inspect a running container just open a new shell with docker exec -it container_id /bin/bash

Can you also have a look at the issues here? https://app.codacy.com/app/scissor-project/open-scissor/issues/index?bid=7022723

Thanks!

Davidepad commented 6 years ago

@ferrarimarco I added ssh inside the containers not to inspect them (I know the exec command) but because D-Streamon master uses Ansible to configure the D-Streamon slave.

Ansible needs ssh to work.

The issues you sent me are related to the D-Streamon core (inside the streamon folder).

That is not code written by me, anyway I can take a look and try to remove the issues

ferrarimarco commented 6 years ago

Great, thanks

Davidepad commented 6 years ago

@ferrarimarco I took a look and there are issues that are part of the code not mine and some are inside libraries.

In addition, 16725 issues are reported and I do not have the time to fix them all, they are really too many

ferrarimarco commented 6 years ago

As you can see from the CI build d-streamon-master and d-streamon-slave are building, so LGTM :) I'll merge as soon as the CI builds are completed.