search

sciter-sdk / rust-sciter

Rust bindings for Sciter
https://sciter.com
MIT License
806 stars 75 forks source link

Simplifying bitflags #89

Open SonnyX opened 3 years ago

SonnyX commented 3 years ago

Another potential way to improve code, albeit at the expense of adding another dependency https://github.com/sciter-sdk/rust-sciter/compare/master...Alovchin91:feature/bitflags

pravic commented 3 years ago

But it's safer. I have to do this eventually.

SonnyX commented 3 years ago

Here is another repo implementing some more bitflags, along with mutability changes and other improvements: https://github.com/sciter-sdk/rust-sciter/compare/master...kwdkk:master

pravic commented 3 years ago

Yeah. The bitflags is a total win but other changes seem controversial and arguable.