Closed ehlertjd closed 6 years ago
Merging #1033 into master will increase coverage by
<.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1033 +/- ##
=========================================
+ Coverage 90.7% 90.7% +<.01%
=========================================
Files 50 50
Lines 6802 6813 +11
=========================================
+ Hits 6170 6180 +10
- Misses 632 633 +1
@nagem Rebased and fixed failing abao tests.
Overall looks good, all the changes to the existing schemas were reasonable and looked correct. At some point I'd like to standardize our example data a bit (we refer to a lot of different example emails ...) but that can come later when we clean up the content of the docs. Thanks for adding an "off switch" as that might help in some scenarios during development.
I'll give it a run locally and give it the final approval after that.
Tests pass and fail as expected (modifying/removing examples). Nice work. Feel free to address anything above before merge but none of it is required for merge IMO.
All tests are currently passing, I have made as few changes to the schemas as possible in order to get tests to pass. There are currently a few exceptions in the
test_validators.py
file that I hope to resolve as part of the larger documentation effort.Review Checklist