scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Allow subject info editing in new style #1039

Closed nagem closed 6 years ago

nagem commented 6 years ago

A lot of this logic can be removed when subject becomes its own container (this is also noted with inline comments). Old methods for modifying subject info are deprecated and will eventually no longer be supported.

Breaking Changes

None

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1039 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1039      +/-   ##
==========================================
+ Coverage   90.69%   90.69%   +<.01%     
==========================================
  Files          50       50              
  Lines        6800     6804       +4     
==========================================
+ Hits         6167     6171       +4     
  Misses        633      633