scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Filter list of groups on GET endpoint when user is site admin #1040

Closed nagem closed 6 years ago

nagem commented 6 years ago

At one point there was a change to the get_all filter that would return all groups to users that were site admins without invoking root=true. Functionality has been returned to the original behavior of only returning all groups (including those the user does not have permission to) when specifically requested through the use of the root flag.

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1040 into master will increase coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1040      +/-   ##
=========================================
+ Coverage   90.69%   90.7%   +0.01%     
=========================================
  Files          50      50              
  Lines        6800    6798       -2     
=========================================
- Hits         6167    6166       -1     
+ Misses        633     632       -1