scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Fix upgrade_to_41() typo #1051

Closed ambrussimon closed 6 years ago

ambrussimon commented 6 years ago

Stumbled into while adding archived->hidden upgrader. PRing separately.

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1051 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1051   +/-   ##
=======================================
  Coverage   91.12%   91.12%           
=======================================
  Files          50       50           
  Lines        6888     6888           
=======================================
  Hits         6277     6277           
  Misses        611      611

nagem commented 6 years ago

Thanks for fixing those changes... I unfortunately tested the query in a local mongo instance rather than through the update db logic.

@ryansanford If any site has taken an update with this update in the release, we should rerun the 41st upgrade on those systems.

nagem commented 6 years ago

FYI: @ambrussimon has a added a new integration test file for testing db upgrades that should be used in the future. It can be found here:

https://github.com/scitran/core/pull/1052/files#diff-bda0ecad35db3f24f177a0603d1adae7