scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Remove archived flag/add hidden tag #1052

Closed ambrussimon closed 6 years ago

ambrussimon commented 6 years ago

Added db upgrade 42 (flag->tag), including limited testing
Removed all archived related logic
Note that there is no hidden feature anymore!
@nagem I had limited insight when editing dataexplorerhandler.py, please take extra care during review

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1052 into master will decrease coverage by 0.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
- Coverage   91.17%   91.15%   -0.02%     
==========================================
  Files          50       50              
  Lines        6898     6887      -11     
==========================================
- Hits         6289     6278      -11     
  Misses        609      609

nagem commented 6 years ago

We'll also want to remove archived from any json schema or example in the documentation layer.

nagem commented 6 years ago

Changes to dataexplorer.py look good 👍