scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Properly 404 on missing file #1065

Closed nagem closed 6 years ago

nagem commented 6 years ago

Fixes #1063

Rearranged the order of operations for GET /api/cont_name/cont_id/files/filename/info so logging happens after the file info has been loaded. Endpoint will now properly 404 on unknown files and containers.

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1065 into master will increase coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1065      +/-   ##
==========================================
+ Coverage   91.18%   91.18%   +<.01%     
==========================================
  Files          50       50              
  Lines        6919     6920       +1     
==========================================
+ Hits         6309     6310       +1     
  Misses        610      610