search

scitran / core

RESTful API
https://scitran.github.io
MIT License
18 stars 18 forks source link

Allow Filenames with slashes #1071

Closed hkethi002 closed 6 years ago

hkethi002 commented 6 years ago

Currently slashes are removed on file upload, we should allow for filenames with slashes, and simply allow it to be a part of the download path.

kofalt commented 6 years ago

I believe this would break our client, which assumes a slash is a directory separator. Are you sure we cannot continue stripping them? Slashes are not a part of a healthy filename.

nagem commented 6 years ago

There were requests to see what changes would be required to store slashes as part of a Mongo object's filename so it could be maintained on download and clients could display the additional path information. This PR is currently a holding ground for @hkethi002 exploratory work.

kofalt commented 6 years ago

Ah, I see you are referencing #1077 :+1:

nagem commented 6 years ago

Exactly, didn't realize we were in the issue not the PR.