scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Use (now available) pypi tempfile backport #1093

Closed ambrussimon closed 6 years ago

ambrussimon commented 6 years ago

Found 3rd party "official" backport of py3 tempfile.

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1093 into master will increase coverage by 0.17%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1093      +/-   ##
==========================================
+ Coverage   90.81%   90.98%   +0.17%     
==========================================
  Files          50       49       -1     
  Lines        7031     7036       +5     
==========================================
+ Hits         6385     6402      +17     
+ Misses        646      634      -12

kofalt commented 6 years ago

This brings back the log spam :pensive: https://travis-ci.org/scitran/core/builds/348324143#L1304

But whatever lol.

gsfr commented 6 years ago

Would be good to silence those warnings. @ambrussimon Worth subclassing? Other options?

ambrussimon commented 6 years ago

@kofalt Thanks for catching that regression. Fixed by disabling warnings with that message.

Also, polling for opinions here about further decreasing test output noise; What do you think about getting rid of the log lines reporting Initialized request ..., at least for tests, using something like if os.environ.get('SCITRAN_RUNTIME_COVERAGE') == 'true'? (Alternative suggestions welcome.)

kofalt commented 6 years ago

I very much would love for that log line be disabled by default.

gsfr commented 6 years ago

I'm definitely in favor of reducing test output noise.