scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Add file and tree browsing to gear suggest endpoint #1097

Closed nagem closed 6 years ago

nagem commented 6 years ago

Tests incoming, functionality not 100% complete.

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1097 into master will decrease coverage by 0.07%. The diff coverage is 88.83%.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   90.91%   90.83%   -0.08%     
==========================================
  Files          49       49              
  Lines        7055     7203     +148     
==========================================
+ Hits         6414     6543     +129     
- Misses        641      660      +19

ryansanford commented 6 years ago

@nagem Looks like the last couple commits are related to tests. Does that suggest you believe the functionality to be complete?

nagem commented 6 years ago

@ryansanford it is ready for review as well as testing with the clients. The format of the response should be the same as the former mocked endpoint but there might be some discrepancies that would be very easy to fix.