scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Signed url upload #1099

Open davidfarkas opened 6 years ago

davidfarkas commented 6 years ago

With this PR the clients will be able to upload files using signed URLs. The only limitation is that only one file can be uploaded per request. The packfile upload is not supported because it is not possible to create the zip file without the API downloads the files again. It is not a braking change, the upload endpoints are backward compatible, so the clients can use the old way.

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

codecov-io commented 6 years ago

Codecov Report

Merging #1099 into generic-storage will increase coverage by 0.02%. The diff coverage is 87.73%.

@@                 Coverage Diff                 @@
##           generic-storage    #1099      +/-   ##
===================================================
+ Coverage            91.05%   91.07%   +0.02%     
===================================================
  Files                   49       49              
  Lines                 7067     7139      +72     
===================================================
+ Hits                  6435     6502      +67     
- Misses                 632      637       +5

nagem commented 6 years ago

I'm not sure what kind of Swagger coverage we have for the engine and reaper upload endpoints, but could you amend and add information about how to use the signed URL ticket method?