scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Fix ticket-based job state transition for analysis jobs #1105

Open ambrussimon opened 6 years ago

ambrussimon commented 6 years ago

Fixes #1084

Mostly copied relevant parts from EnginePlacer (DRY suggestions welcome)
Added tests

Review Checklist

Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md

ryansanford commented 6 years ago

@nagem @ambrussimon Please confirm if this adds any risk for endpoints in use, so we can decide whether to hold this merge for after the imminent release. Thanks.

codecov-io commented 6 years ago

Codecov Report

Merging #1105 into master will increase coverage by 0.05%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   90.92%   90.98%   +0.05%     
==========================================
  Files          49       49              
  Lines        7055     7068      +13     
==========================================
+ Hits         6415     6431      +16     
+ Misses        640      637       -3

ambrussimon commented 6 years ago

@ryansanford Change scope is limited to POST /upload/engine?level=analysis and should be only additive in terms of functionality. Personally I think the risk is minimal.