search

scitran / core

RESTful API
https://scitran.github.io
MIT License
18 stars 18 forks source link

Removed a few dozen unhelpful log statements #978

Closed kofalt closed 6 years ago

kofalt commented 6 years ago

This is driving me a little batty and making the logs hard to read, so I fixed it.

Every log.debug that doesn't have some information attached to it has been removed, excepting some in config.py because... fine. Oh, and I removed the every-request line that benchmarks our database!

If one of these is important to you, please add it back with more information - and make it conditional.

When I decided to improve this, there were about ~40 calls to log.debug, many of them in code paths that tend to be called on many / most / all requests. Now there are about 14. I also got rid of one log.info, the rest seemed fine.

codecov-io commented 6 years ago

Codecov Report

Merging #978 into master will decrease coverage by 0.01%. The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #978      +/-   ##
========================================
- Coverage   90.01%    90%   -0.02%     
========================================
  Files          49     49              
  Lines        6671   6640      -31     
========================================
- Hits         6005   5976      -29     
+ Misses        666    664       -2
kofalt commented 6 years ago

You're a real piece of work, codecov.

nagem commented 6 years ago

LGTM, these should definitely be removed.