scitran / core

RESTful API

https://scitran.github.io

MIT License

18 stars 18 forks source link

Correct match_ids in containerhandler.get_jobs #979

Closed kofalt closed 7 years ago

kofalt commented 7 years ago

Resolves #972

Yeah, really dumb error here. Late night bug fixes :couch_and_lamp: :tumbler_glass:

codecov-io commented 7 years ago

Codecov Report

Merging #979 into master will increase coverage by 0.04%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage      90%   90.04%   +0.04%     
==========================================
  Files          49       49              
  Lines        6640     6640              
==========================================
+ Hits         5976     5979       +3     
+ Misses        664      661       -3

nagem commented 7 years ago

Changes LGTM.

Please add a test to ensure utility and analysis jobs are properly returned via this endpoint. The code is covered, probably just need to modify an existing test to ensure utility and analysis jobs are returned.

ryansanford commented 7 years ago

I confirmed this is resolving #972 on my local dev. Thanks @kofalt . I added that issue to the PR description. Assigning back to you for the requested test improvement.

ryansanford commented 7 years ago

LGTM