Closed hkethi002 closed 6 years ago
:exclamation: No coverage uploaded for pull request base (
PHI-perm-three@406ac2d
). Click here to learn what that means. The diff coverage is92.33%
.
@@ Coverage Diff @@
## PHI-perm-three #991 +/- ##
=================================================
Coverage ? 91.17%
=================================================
Files ? 51
Lines ? 7049
Branches ? 0
=================================================
Hits ? 6427
Misses ? 622
Partials ? 0
Closing PR for now as requirements for this enhancement are reworked within the team.
Fixes #944
Changes From #877
phi
field (required field when creating project)project.phi
== true, projects can have custom phi listmodify-phi-list
ToDo
[x] Project phi field that enables phi functionality
[x] Subfields of PHI_CANDIDATES need to be permitted as phi fields
[x] Log changes made to custom phi lists
[x] Add more tests
[x] Redo the phi logic for list handlers (Notes and Tags)
Review Checklist
Tests were added to cover all code changes
Documentation was added / updated
Code and tests follow standards in CONTRIBUTING.md