Closed kofalt closed 6 years ago
:exclamation: No coverage uploaded for pull request base (
master@9301a8d
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #995 +/- ##
=========================================
Coverage ? 90.23%
=========================================
Files ? 49
Lines ? 6688
Branches ? 0
=========================================
Hits ? 6035
Misses ? 653
Partials ? 0
It really doesn't make sense to call the module with the parent class container
when the module with the child classes is containerstorage
. I would be more willing to call it basecontainerstorage
, but that is very long.
Agreed - I would probably have gone with containerstorage
and then containerstorage_implementations
or cs_impls
or something, but then we're renaming 2 files and changing ~30 imports instead of 1 & 3, and that seemed a bit much for code that I don't own... etc.
I'll rename it to basecontainerstorage
for now then :+1:
Updated & green
Cool, go ahead 👍
Closes #977. I keep running into this, so I hope nobody minds if this rename fixes things for now. Comments on the linked ticket suggest a better long term fix.
This was simply the smallest change, alternatives accepted. I would probably call several files in dao differently, but I didn't want to cause a lot of churn without a better reason to do so.