search

sciurus / vagrant-mutate

Convert vagrant boxes to work with different providers
MIT License
281 stars 41 forks source link

added --force-virtio switch #81

Closed cg5labs closed 8 years ago

cg5labs commented 8 years ago

Hi Brian,

I've added the --force-virtio switch to the command arguments and modified the flow so that it is only forwarded on calls to convert to libvirt output provider.

Can you please have a look at it?

Thanks in advance!

Chris

sciurus commented 8 years ago

Hi Chris,

Thanks for taking on this work! A few thoughts for you:

1) I don't think you need to touch box/box.rb, box/libvirt.rb, or box_loader.rb at all. In mutate.rb what if you pass the force_virtio option through Converter::Converter.create instead of through output_loader.prepare_for_output? Then I think the changes could be confined to that file converter/converter.rb, and converter/libvirt.rb.

2) You could add support for this to the kvm converter too. Take a look at converter/libvirt.rb and box.xml.erb in the templates dir.

And a few thoughts for me:

1) box_loader.rb is such a mess.

2) Should I just drop support for vagrant-kvm? The project is abandoned.

sciurus commented 8 years ago

Sorry to see you abandon this.