search

sciurus / vagrant-mutate

Convert vagrant boxes to work with different providers
MIT License
280 stars 41 forks source link

added --force-virtio switch (refactored) #82

Closed cg5labs closed 8 years ago

cg5labs commented 8 years ago

Hi Brian,

Sorry for the misunderstanding! I was done with the code revision yesterday and only deleted the old branch because I created a new one. Only didn't get to submit the new pull request as it was quite late already when I was done.

Thanks for your feedback, I've rewritten the parameter based on your feedback and indeed could confine the changes to the three files.

For the vagrant-kvm support, I think it's better to drop it. As you said, the project is abandoned. Also, I remember trying out vagrant-kvm for libvirt/kvm on CentOS before vagrant-libvirt and didn't get it to work at all.

A Vagrant provider that I want to work with soon too is vagrant-xenserver as I work on projects with Xen hypervisor a lot at my current job. Looking at the plugin, it doesn't look too complex to include support in vagrant-mutate, it's a very basic Vagantfile and a qemu-img call to convert a vmdk to a vhd disk image. Do you think this is good to support in vagrant-mutate? From what I've seen, Xenserver is still in use in a lot of places.

I've also found https://github.com/sciurus/vagrant-mutate/issues/78 in the open issues and can try to implement that next.

Anyways, really sorry for the confusion. Vagrant-mutate is the first project on github that I want to contribute to and your comments were very helpful for me to improve on my previous attempt.

Thanks!

Chris

sciurus commented 8 years ago

I made a few more suggestions.

I checked out vagrant-xenserver, adding support for it looks like a great idea! Like you said, it shouldn't be too difficult.

sciurus commented 8 years ago

BTW, instead of closing your PR and creating a new one, you can continue to push changes to your branch and this PR will automatically update to reflect them.

cg5labs commented 8 years ago

I updated the code on your feedback over the weekend. Can you please have a look at it? Thanks!

sciurus commented 8 years ago

Hi Chris, Thanks for the revisions! I'll take a look when I can, I'm not sure when that will be yet. I have a 4 day old infant on my hands. :-) On Feb 15, 2016 01:35, Chris Scheible notifications@github.com wrote:I updated the code on your feedback over the weekend. Can you please have a look at it? Thanks!

—Reply to this email directly or view it on GitHub.

sciurus commented 8 years ago

I've released this in 1.1.0. Thanks for your contribution! I hope to see more!