search

sciurus / vagrant-mutate

Convert vagrant boxes to work with different providers
MIT License
281 stars 41 forks source link

Convert VirtualBox parser to using nokogiri #89

Closed swills closed 8 years ago

swills commented 8 years ago

Convert VirtualBox parser to using nokogiri instead of rexml. This allows us to use namespace agnostic xpaths, so that we successfully parse some ovf files which use namespaces in unexpected ways. Fixes #88

Shouldn't cause any additional burden since Vagrant requires nokogiri anyway. Also add nokogiri to gemspec for correctness. Perhaps other parsers should be converted as well.

swills commented 8 years ago

All tests pass, with the test changes in #86.

sciurus commented 8 years ago

After this change there would only be one place left where we're using rexml. Could you convert it too?

https://github.com/sciurus/vagrant-mutate/blob/a948b80f1b332e7c59cc41eec0feb3b49cd4d508/lib/vagrant-mutate/box/kvm.rb#L24

swills commented 8 years ago

Done, and it passes tests, but I'm still not completely confident in it. Could use more testing by someone who has kvm.