search

scivision / linkchecker-markdown

Python asyncio + aiohttp Markdown *.md URL link checker: 10,000 files/second
MIT License
32 stars 18 forks source link

links in markdown codeblocks are being checked #13

Open sappelhoff opened 3 years ago

sappelhoff commented 3 years ago

Hi, thanks a lot for your package!

Using the up-to-date pip install of the package, the following URL is flagged when running from the command line:

`[[URL](URL)]`

this is in line 352 of this file: https://github.com/sappelhoff/bids-specification/blob/master/CONTRIBUTING.md

I would have expected links in markdown inline code blocks to not be checked. Is that a wrong expectation? Or is it something to improve in the code?

scivision commented 3 years ago

It's something to improve. I hadn't made the regular expression used that complicated so this is something that would happen yes. At some point, there would be a speed penalty as the regex gets more an more complicated