Should there be an output when deleting rule?

sckott / cchecksapi

CRAN checks API (DEFUNCT)

https://github.com/r-hub/cchecksbadges

MIT License

33 stars 1 forks source link

Should there be an output when deleting rule? #65

Closed maelle closed 4 years ago

maelle commented 4 years ago

When creating rules there's "success" as an output. I'd expect something similar for rule deletion maybe?

sckott commented 4 years ago

its typical to have no content in response body on DELETE success, and status code 204 - so i followed that pattern - i think in R it returns TRUE on success, and if it fails then raises whatever error happened. does that make sense?

maelle commented 4 years ago

it does make sense!