Closed bgreenwell closed 5 years ago
Ahh, my apologies, that is an asci image of Chuck Norris! In particular, it is an ascii image of
Im am able to make a more refined version as well, but I settled on this size as a compromise.
thanks for the clarification. So you made the ascii ? just checking.
Do you think you could alter it at all? I don't really see the resemblance. I mean I can't really tell that it's supposed to look like Chuck Norris.
What do you think @aedobbyn ?
I agree with @sckott. Size isn't a big issue, at least not vertical size (see e.g. yoda and endless horse. I think bigger with more detail is the right tradeoff to make. Also, if you made it @bgreenwell feel free to add your sig, if you want :)
I generated the ascii, but the image is from google, and used as part of this package's logo.
I can certainly increase the size, but what do you think would be a reasonable max width, 80 characters (that's just slightly larger than what = "bat2"
? Let me know and I will submit a new pull request.
80 seems reasonable to me, I probably wouldn't go any wider
@bgreenwell you don't have to create a new PR, you can just add commits to this PR (i.e., bgreenwell:master
branch)
Will do!
Referencing this pull request.
LGTM, any thoughts @aedobbyn ?
Looks great, nice work @bgreenwell!
thanks @bgreenwell
thanks @bgreenwell
Can you give some context for this. What is chuck?
I see
Is this as intended? I don't quite see a shape there.