sckott / cowsay

cowsay w/ more animals, in R
https://sckott.github.io/cowsay/
Other
310 stars 49 forks source link

add chuck #62

Closed bgreenwell closed 5 years ago

sckott commented 6 years ago

thanks @bgreenwell

Can you give some context for this. What is chuck?

I see

 ------
    \
     \
      @@@@@@@
      @@@@@@@@
     @@@@@@@@@@
     @@@@@@@@@@@@@@
  @@@@  @@   @@@@@@
               @@
       @@@   @@@
      @   @   @
       @@    @@@
  @@@@ @@@@@@@@@@@ [nosig]

Is this as intended? I don't quite see a shape there.

bgreenwell commented 6 years ago

Ahh, my apologies, that is an asci image of Chuck Norris! In particular, it is an ascii image of chuck-norris

Im am able to make a more refined version as well, but I settled on this size as a compromise.

sckott commented 6 years ago

thanks for the clarification. So you made the ascii ? just checking.

Do you think you could alter it at all? I don't really see the resemblance. I mean I can't really tell that it's supposed to look like Chuck Norris.

What do you think @aedobbyn ?

aedobbyn commented 6 years ago

I agree with @sckott. Size isn't a big issue, at least not vertical size (see e.g. yoda and endless horse. I think bigger with more detail is the right tradeoff to make. Also, if you made it @bgreenwell feel free to add your sig, if you want :)

bgreenwell commented 6 years ago

I generated the ascii, but the image is from google, and used as part of this package's logo.

I can certainly increase the size, but what do you think would be a reasonable max width, 80 characters (that's just slightly larger than what = "bat2"? Let me know and I will submit a new pull request.

aedobbyn commented 6 years ago

80 seems reasonable to me, I probably wouldn't go any wider

sckott commented 6 years ago

@bgreenwell you don't have to create a new PR, you can just add commits to this PR (i.e., bgreenwell:master branch)

bgreenwell commented 6 years ago

Will do!

bgreenwell commented 5 years ago

Referencing this pull request.

sckott commented 5 years ago

LGTM, any thoughts @aedobbyn ?

aedobbyn commented 5 years ago

Looks great, nice work @bgreenwell!

sckott commented 5 years ago

thanks @bgreenwell