Default to type="print" in noninteractive mode

sckott / cowsay

cowsay w/ more animals, in R

https://sckott.github.io/cowsay/

Other

308 stars 49 forks source link

Default to type="print" in noninteractive mode #72

Closed aedobbyn closed 5 years ago

aedobbyn commented 5 years ago

The way I'm handling the default type now is to set it to null by default and then assign it to "message" if in interactive and "print" if in noninteractive mode to address the other half of #70. Otherwise, type is whatever the user specifies.

If there's a different approach, happy to change it up!

aedobbyn commented 5 years ago

I think appveyor failed because it had trouble installing dplyr? 🤔

Btw I had to open this in Safari to be able to see where the error happened since you can't see the logs in Chrome for me past a certain point 🤷‍♀

sckott commented 5 years ago

nice! works well