sckott / habanero

client for Crossref search API
https://habanero.readthedocs.io
MIT License
207 stars 30 forks source link

style not functioning/not getting passed to request #57

Closed ColinTalbert closed 7 years ago

ColinTalbert commented 7 years ago

I can't seem to get different citation styles to work. I think I've tracked the problem down to: https://github.com/sckott/habanero/blob/master/habanero/cnrequest.py#L46

if I copy/duplicate the lines: https://github.com/sckott/habanero/blob/master/habanero/cnrequest.py#L39-L40 after that line it starts working for me.

Environment: Windows 64, Python 3.4, habanero installed from: https://anaconda.org/conda-forge/habanero

I can submit a pull request if you think it worthwhile

sckott commented 7 years ago

@talbertc-usgs thanks for this. Your reasoning looks right to me. Sorry I missed that. A PR would be great. Can you include a test too for that fix?

ColinTalbert commented 7 years ago

You bet. It might take me a few days but sure.

On Tue, Jul 18, 2017 at 12:30 PM, Scott Chamberlain < notifications@github.com> wrote:

@talbertc-usgs https://github.com/talbertc-usgs thanks for this. Your reasoning looks right to me. Sorry I missed that. A PR would be great. Can you include a test too for that fix?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sckott/habanero/issues/57#issuecomment-316155210, or mute the thread https://github.com/notifications/unsubscribe-auth/AWHgahXiIWdM6Ld5edd6nELqHCzUYErYks5sPPm4gaJpZM4ObvZz .

-- Colin Talbert Data Manager, Analyst and Developer US Geological Survey, Fort Collins Science Center 2150 Centre Ave. Bldg. C Fort Collins, CO 80526 (970) 226-9425 http://orcid.org/0000-0002-9505-1876

Work schedule: Monday - 12:00 - 6:30 Tuesday - Thursday - 7:00 - 3:30 Friday - 7:00 - 5:30

sckott commented 7 years ago

Okay, thanks

sckott commented 7 years ago

fix via #58