sckott / mutant-proposal

https://sckott.github.io/mutant-proposal/
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

Look over proposal? #1

Open sckott opened 3 years ago

sckott commented 3 years ago

@evaristor I'm submitting a proposal to the R Consortium https://www.r-consortium.org/projects/call-for-proposals to fund work on mutant. Would you have time to look over the proposal?

You can see it at https://sckott.github.io/mutant-proposal/ and pdf here https://sckott.github.io/mutant-proposal/index.pdf

You can open an issue or send a PR, whatever you like

devarops commented 3 years ago

I'll gladly look over the proposal within the next few days.

sckott commented 3 years ago

thanks!

devarops commented 3 years ago

The proposal looks great! I'll leave my comments here if that is OK with you.

In lines 46-53:

Create two mutants:

less_than_ten <- function(x) {
  z <- x - 5 # changed + to -
  z < 7 # 10 changed to 7
}

I would separete the mutants in two blocks of code:

Create two mutants. The first mutant changes an operator:

less_than_ten <- function(x) {
  z <- x - 5 # changed + to -
  z < 10
}

The second mutant changes a constant:

less_than_ten <- function(x) {
  z <- x + 5
  z < 7 # 10 changed to 7
}
devarops commented 3 years ago

Even though this is true,

Mutation testing in the R community will not be used as widely as unit testing - not every one that uses unit testing will use mutation testing,

I wouldn't put such an emphasis on it. Maybe you could just start the paragraph with the second sentence. Something like this:

Members of the R community that will find mutation testing most useful will likely be: (...)

sckott commented 3 years ago

Thanks very much! This is very helpful

devarops commented 3 years ago

In line 24,

Mutant should be easily extended to the other two testing packages.

consider using lowercase:

mutant should be easily extended to the other two testing packages.

devarops commented 3 years ago

Sometimes you use plural (We'll) and some time you use singular (I'll)

We’ll address the (...). I’ll leverage the (...)

Probably the plural form sounds better

devarops commented 3 years ago

That's all my feedback. Good luck!