Am I doing anything right?

[sckott]

Hey @bendmorris, I am playing around porting taxize to Python. Curious if you can take a quick look at my code, see https://github.com/sckott/pytaxize/blob/master/pytaxize/tax.py There are examples in the docstrings areas.

And perhaps tell me if I'm on the right track creating a Python package.

[bendmorris]

Looks great!

• One thing you'll want to do is add a "requires" flag in your setup.py script - something like

  requires=['requests', 'pandas', 'BeautifulSoup'],

  to make sure those packages are installed first.

• Also, explicitly handling exceptions is nice - for example, if I call gnr_resolve('abcdefg') I get "KeyError: 'results'" - I should probably get an exception that tells me in plain English that there was no result.
• Since you're already using examples in your docstrings (good practice, very helpful) you might be interested in doctest: http://docs.python.org/2/library/doctest.html which really easily turns those examples into unit tests.

It seems like you're doing just fine. Anything specific I can help with? Happy to throw together a pull request with what I mentioned above if you like.

[sckott]

Thanks so much Ben!

That would great if you could send a pull request with one thing: an example of how to properly do error handling

I'll make an issue for each of these to properly keep track of each.

[sckott]

cool, thanks ben, closing this as in separate issues now