search

sckott / serrano

Low level Ruby client for Crossref
https://rubydoc.info/gems/serrano
MIT License
31 stars 3 forks source link

Resolve DOIs securely #49

Closed katrinleinweber closed 6 years ago

katrinleinweber commented 6 years ago

Hello :-)

The DOI foundation recommends this new, secure resolver. Accordingly, this PR updates the URL prefix used in HTTP requests. If I understood the code correctly.

Cheers!

codecov-io commented 6 years ago

Codecov Report

Merging #49 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   83.13%   83.13%           
=======================================
  Files          20       20           
  Lines         670      670           
=======================================
  Hits          557      557           
  Misses        113      113
Impacted Files Coverage Δ
lib/serrano/cnrequest.rb 33.33% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b54a56...c8400aa. Read the comment docs.

sckott commented 6 years ago

thanks @katrinleinweber very much, looks good!

katrinleinweber commented 6 years ago

You're welcome! Shall I treat habanero as well?

sckott commented 6 years ago

thanks - but I just checked, and I think (not 100% sure though) it's all good. there is a lot of dx.doi.org but in responses from crossref in the cached test suite responses, and i have an example in the docs where the user can change the base url to dx.doi.org