sclasen / akka-kafka

185 stars 62 forks source link

Can AkkaConsumber inherit from a common base trait? #48

Open coreyauger opened 8 years ago

coreyauger commented 8 years ago

I would like to have a common base for akka consumers... to allow for a generic way to process clean-up

ex: private[this] val consumerRegistry = new ConcurrentHashMap[String, AkkaConsumerBase[String, _]] `

def shutdown() = {
    logger.info("Shutting down Event Bus")
    producer.close()
    Await.ready(Future.sequence(consumerRegistry.map(e => e._2.stop())), 5 minute)
  }

Thoughts ?

sclasen commented 8 years ago

seems legit, want to do a PR?

coreyauger commented 8 years ago

Sounds good :)