search

sclem / pfcrypto

chome extension to automatically update cryptocurrency holdings in personal capital
https://chrome.google.com/webstore/detail/pfcrypto/ceepigemlmlbphjhffddplfecgedhoeb
MIT License
48 stars 11 forks source link

Fix ticker match when crypto name contains a dash #1

Closed bhipple closed 7 years ago

bhipple commented 7 years ago

The coinmarketcap api ticker name for Bitcoin Cash is "bitcoin-cash", and Ethereum Classic is "ethereum-classic". Also removed the A-Z from the regex match, since we're calling toLowerCase already.

Tested with a BTC, BCH, ETH, and ETC portfolio. This plugin is really neat btw, thanks!

bhipple commented 7 years ago

For the record, it seems to be updating all of the tickers in a single portfolio without issue.

sclem commented 7 years ago

Tested, works great. Will bump version num and update the extension in the store, thanks!