search

sclevine / agouti

A WebDriver client and acceptance testing library for Go
MIT License
821 stars 103 forks source link

support geckodriver (Firefox) #150

Closed koron closed 6 years ago

koron commented 6 years ago

This PR adding support for geckodriver which works with Firefox or gecko based browsers.

I know other PR https://github.com/sclevine/agouti/pull/66 exists. But it seems be stagnant, so I create a revised one.

koron commented 6 years ago

Please check https://github.com/ariya/phantomjs/issues/13409 and https://github.com/ariya/phantomjs/issues/14228 for the reason of failure.

sclevine commented 6 years ago

Thanks for the PRs!

I'll merge this now, but it would be awesome if you could:

  1. Add this to the list of browsers that are integration tested in the internal/integration package.
  2. Add a unit test for the fallback behavior in the bus.