Closed ms32035 closed 1 year ago
Ok, I incorporated all the changes and later tested the upgrade script to upgrade to 1.2.23. Everything looks to be working ok
I tested with your latest changes. cron
is again running the poller. And the issues with csrf are resolved.
Now I'm seeing the poller timeout and throw a bunch of PHP errors:
2023-01-02 13:30:01 - CMDPHP PHP ERROR Backtrace: (CactiShutdownHandler())
2023-01-02 13:30:01 - ERROR PHP ERROR: Uncaught TypeError: Unsupported operand types: array & bool in /cacti/lib/mib_cache.php:344 Stack trace: #0 /cacti/lib/mib_cache.php(384): MibCache->delete() #1 /cacti/lib/snmpagent.php(352): MibCache->replace() #2 /cacti/poller.php(767): snmpagent_poller_bottom() #3 {main} thrown in file: /cacti/lib/mib_cache.php on line: 344
2023-01-02 13:30:01 - CMDPHP PHP ERROR WARNING Backtrace: (/poller.php[705]:snmpagent_poller_exiting(), /lib/snmpagent.php[302]:CactiErrorHandler())
2023-01-02 13:30:01 - ERROR PHP WARNING: Trying to access array offset on value of type bool in file: /cacti/lib/snmpagent.php on line: 302
Is Cacti ready for the version of PHP bundled with Rocky 9?
Never seen this, looks more like something specific to your installation.
Thanks for the PR, will do some basic checks this weekend and if all looks good will merge before Monday (^_^)
@scline did you manage to test it?
correct, with csrf secrets I just manually changed the permissions once.
How do you want to proceed with this? Feel free to pick the changes and apply to another branch if you want to. Otherwise you can also push your stuff here.