search

sclorg / container-common-scripts

Apache License 2.0
20 stars 45 forks source link

Fix ct_os_test_image_update #225

Closed phracek closed 2 years ago

phracek commented 2 years ago

Service name has a wrong name: oc new-app php:7.3~https://github.com/sclorg/s2i-php-container.git --context-dir=7.3/test/test-app --name php-73-centos7:7.3

And --name should be php-73-centos7-testing

The function itself is used only here: https://github.com/search?q=org%3Asclorg+ct_os_test_image_update&type=code

And nowadays only here: https://github.com/search?q=org%3Asclorg+ct_os_test_image_update&type=code Signed-off-by: Petr "Stone" Hracek phracek@redhat.com

phracek commented 2 years ago

[test]

phracek commented 2 years ago

This pull request blocks https://github.com/sclorg/s2i-php-container/pull/344

phracek commented 2 years ago

The tests are not relevant for this change. Because of I need to fix s2i-php-container. I am going to merge it.

A similar approach is here: https://github.com/sclorg/mariadb-container/blob/master/test/test-lib-mysql.sh#L67 https://github.com/sclorg/mariadb-container/blob/master/test/test-lib-mysql.sh#L67

phracek commented 2 years ago

Fedora and RHEL 8 test failed:

10:45:46                 out:  [PASSED] for 'hw' test_incremental_build
10:45:46                 out:  [PASSED] for 'hw' test_build_express_webapp
10:45:46                 out:  [PASSED] for 'clients' express
10:45:46                 out:  [FAILED] for 'clients' pino
10:45:46                 out:  [PASSED] for 'clients' prom-client
10:45:46                 out:  [PASSED] for 'binary' test_run_binary_application