search

sclorg / container-common-scripts

Apache License 2.0
20 stars 45 forks source link

Deploy image into internal OpenShift registry. #252

Closed phracek closed 2 years ago

phracek commented 2 years ago

We do not need an external registry at all.

By setting the variable CT_OCP4_TEST we use OpenShift 4 internal registry.

Signed-off-by: Petr "Stone" Hracek phracek@redhat.com

hhorak commented 2 years ago

LGTM, with just 2 small nitpicks to consider, nothing from that is a blocker for merging though.

phracek commented 2 years ago

[test]

phracek commented 2 years ago

[test]

phracek commented 2 years ago

Rebased

[test]

hhorak commented 2 years ago

Cool, sounds good, thanks. LGTM now.