search

sclorg / container-common-scripts

Apache License 2.0
20 stars 45 forks source link

support for run_test_cb #268

Closed zmiklank closed 2 years ago

zmiklank commented 2 years ago

This change should be backward compatible. It is needed because of moving s2i-nodejs container tests to generic test function. However, I suppose there will be also other containers like this. See some info in the commit message.

zmiklank commented 2 years ago

[test-all]

zmiklank commented 2 years ago

I have rebased on master. [test-all]

zmiklank commented 2 years ago

Sure.

Some containers (in this case the s2i-nodejs one) have more complex test execution than ordinary container images. These can write their own function for this, as in here. If this is not needed, then the run_test_cb is defined directly in the ct_run_tests_from_testset, see here https://github.com/sclorg/container-common-scripts/blob/09e45fc6ab0c29f8cb2b61b0f8278a2f472aaa43/test-lib.sh#L1147 The run_test_cb is defined in ct_run_tests_from_testset, only if not defined before.

phracek commented 2 years ago

@zmiklank This is not needed now, I guess. Right?

zmiklank commented 2 years ago

Yes, I need to rework this.