Closed zmiklank closed 2 years ago
@zmiklank One nitpick ;) Why is it not written in Python? Tests are missing and it would be easier to write them in python. We need some GitHub token or credentials for pushing PR, right? Do you count on testing them?
@phracek, thanks for the review.
I've chosen shell, as all of the container-common-scripts are written in shell. I can of course add some tests, as you suggested.
We do not need token on credentials, as this script is meant to be run from localhost, using the credentials of the user.
@phracek thanks again, could you please look into the replies I wrote?
Also, I changed the container image name format from s2i-base
to s2i-base-container
, etc.
[test-all]
[test-all]
@zmiklank Please rebase this pull request against master. Thank you.
[test]
The script would pull specified SCLORG container image git repositories, commits there an update of common/ submodule to the latest origin/master commit or a specified commit. Then the changes would be pushed to the repositories with the user's ssh key.
The script should meet the following rules:
make push-to-containers
doublecheck if the commit is OK to push
WDYT?