search

sclorg / container-common-scripts

Apache License 2.0
21 stars 45 forks source link

do not use --iidfile parameter in docker build #315

Closed zmiklank closed 1 year ago

zmiklank commented 1 year ago

[test-all]

zmiklank commented 1 year ago

I also tested this on rhel7 machine with docker installed and it worked.

zmiklank commented 1 year ago

I really do not want to build a container twice, because some layers already exist.

That is even better for us. We would need only the logs from the failing layer anyway.

zmiklank commented 1 year ago

[test]

phracek commented 1 year ago

s2i-base-container is failing here for CentOS 7 and RHEL7:

Testing 'cgroup limits' usage...
  The test is running as root, all tests for cgroup limits will be run
  Testing 'limited memory' usage...
Traceback (most recent call last):
  File "/usr/bin/cgroup-limits", line 180, in <module>
    "NUMBER_OF_CORES": get_number_of_cores()
  File "/usr/bin/cgroup-limits", line 97, in get_number_of_cores
    limits = [l for l in [_read_cpu_quota(), _read_cpuset_size(), _read_nproc()] if l]
  File "/usr/bin/cgroup-limits", line 172, in _read_nproc
    except FileNotFoundError:
NameError: global name 'FileNotFoundError' is not defined
MEMORY_LIMIT_IN_BYTES=
test/run: line 25: [: : integer expression expected
MEMORY_LIMIT_IN_BYTES not set to 536870912.

It should be fixed by #322

phracek commented 1 year ago

And for RHEL8 there are failing for reason:

Testing 'cgroup limits' usage...
  The test is running as root, all tests for cgroup limits will be run
  Testing 'limited memory' usage...
Traceback (most recent call last):
  File "/usr/bin/cgroup-limits", line 180, in <module>
    "NUMBER_OF_CORES": get_number_of_cores()
  File "/usr/bin/cgroup-limits", line 97, in get_number_of_cores
    limits = [l for l in [_read_cpu_quota(), _read_cpuset_size(), _read_nproc()] if l]
  File "/usr/bin/cgroup-limits", line 171, in _read_nproc
    return int(subprocess.run('nproc', capture_output=True).stdout)
  File "/usr/lib64/python3.6/subprocess.py", line 423, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'
MEMORY_LIMIT_IN_BYTES=
test/run: line 25: [: : integer expression expected
MEMORY_LIMIT_IN_BYTES not set to 536870912.
zmiklank commented 1 year ago

And for RHEL8 there are failing for reason:

Testing 'cgroup limits' usage...
  The test is running as root, all tests for cgroup limits will be run
  Testing 'limited memory' usage...
Traceback (most recent call last):
  File "/usr/bin/cgroup-limits", line 180, in <module>
    "NUMBER_OF_CORES": get_number_of_cores()
  File "/usr/bin/cgroup-limits", line 97, in get_number_of_cores
    limits = [l for l in [_read_cpu_quota(), _read_cpuset_size(), _read_nproc()] if l]
  File "/usr/bin/cgroup-limits", line 171, in _read_nproc
    return int(subprocess.run('nproc', capture_output=True).stdout)
  File "/usr/lib64/python3.6/subprocess.py", line 423, in run
    with Popen(*popenargs, **kwargs) as process:
TypeError: __init__() got an unexpected keyword argument 'capture_output'
MEMORY_LIMIT_IN_BYTES=
test/run: line 25: [: : integer expression expected
MEMORY_LIMIT_IN_BYTES not set to 536870912.

I think this is, however, not caused or related to this PR.